Fix redis test #15247
Merged
Fix redis test #15247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepthiYV
force-pushed
the
redis
branch
3 times, most recently
from
e9f5c96
to
4f64f8a
Compare
DeepthiYV
force-pushed
the
redis
branch
2 times, most recently
from
5915da9
to
dd70013
Compare
DeepthiYV
force-pushed
the
redis
branch
4 times, most recently
from
b9e035a
to
29b5a6d
Compare
rfan1
reviewed
Aug 8, 2022
data/console/redis_cli.sh
Outdated
Comment on lines
46
to
47
| # Connect to the new instance of redis-server with port 6380 and make 6380 instance | ||
| #a replica of redis instance running on port 6379 and verify the reslt |
There was a problem hiding this comment.
minor comments:
and make 6380 -> delete the blank
verify the reslt -> result?
There was a problem hiding this comment.
Correction is done. Thanks for the heads up
rfan1
reviewed
Aug 8, 2022
tests/console/redis.pm
Outdated
| sub run_script { | ||
| my $script = shift; | ||
| my $logfile = "output.txt"; | ||
| record_info($script, "Running python script: $script"); |
There was a problem hiding this comment.
IMO, it should be a shell script, but please omit my comment if I am wrong
data/console/redis_cli.sh
Outdated
| echo "redis-cli info replication on master" | ||
| else | ||
| echo "Failed: redis-cli info replication on master" | ||
|
|
data/console/redis_cli.sh
Outdated
| echo "Role:slave in redis-cli on replica" | ||
| else | ||
| echo "Failed: redis-cli info replication on replica" | ||
|
|
There was a problem hiding this comment.
Deleted. Thanks Richard
DeepthiYV
force-pushed
the
redis
branch
2 times, most recently
from
e2336fc
to
22220d2
Compare
rfan1
approved these changes
Aug 9, 2022
foursixnine
reviewed
Aug 12, 2022
data/console/redis_cli.sh
Outdated
| then | ||
| echo "redis-cli info replication on master" | ||
| else | ||
| echo "Failed: redis-cli info replication on master" |
There was a problem hiding this comment.
Suggested change
| echo "Failed: redis-cli info replication on master" | |
| echo "Failed: redis-cli info replication on master, slave took longer than 10 seconds to show up" |
foursixnine
reviewed
Aug 12, 2022
Comment on lines
+73
to
+80
| out=$(redis-cli -p 6380 HMGET "movie:343" title) | ||
| if [ "$out" = "Spider-Man" ] | ||
| then | ||
| echo "redis-cli replicaof done" | ||
| else | ||
| echo "Failed: redis-cli replication on replica " | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Can you create a follow up ticket to rework this in the future?, i.e: add an extra check to know the status of the replication (basically, know if the replica is in sync with the master)
There was a problem hiding this comment.
created ticket: https://progress.opensuse.org/issues/115592
foursixnine
approved these changes
Aug 12, 2022
foursixnine
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLE 15 SP3 - x86_64 | s390x| | aarch64
SLE 15 SP2 - x86_64 | s390x| | aarch64
SLE 15 SP4 - x86_64 | ppc64le| | aarch64 | svirt-xen-hvm | svirt-xen-pv | s390x
LEAP: x86_64
Tumbleweed: x86_64